Skip to content

Commit

Permalink
[PATCH] pcnet32: Prevent hang with 79c976
Browse files Browse the repository at this point in the history
Some boards using the 79c976 pcnet32 chip will hang the system if the
ethtool --register-dump is performed with the device operational.  The
request to read bcr30 is retried by the PCI device infinitely without
returning data, hanging the system.

Tested ia32 and ppc64.

Signed-off-by:  Don Fry <brazilnut@us.ibm.com>
Signed-off-by: Jeff Garzik <jgarzik@pobox.com>
  • Loading branch information
Don Fry authored and Jeff Garzik committed Nov 5, 2005
1 parent 2964bbd commit 4371dc6
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion drivers/net/pcnet32.c
Original file line number Diff line number Diff line change
Expand Up @@ -988,7 +988,11 @@ static void pcnet32_get_regs(struct net_device *dev, struct ethtool_regs *regs,
*buff++ = a->read_csr(ioaddr, 114);

/* read bus configuration registers */
for (i=0; i<36; i++) {
for (i=0; i<30; i++) {
*buff++ = a->read_bcr(ioaddr, i);
}
*buff++ = 0; /* skip bcr30 so as not to hang 79C976 */
for (i=31; i<36; i++) {
*buff++ = a->read_bcr(ioaddr, i);
}

Expand Down

0 comments on commit 4371dc6

Please sign in to comment.