Skip to content

Commit

Permalink
Bluetooth: Use memdup_user in le_auto_conn_write()
Browse files Browse the repository at this point in the history
This patch does a small code simplification replacing the tipical
kmalloc-copy_from_user sequence by memdup_user() helper.

Cc: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
  • Loading branch information
Andre Guedes authored and Marcel Holtmann committed Mar 26, 2014
1 parent 4af605d commit 4408dd1
Showing 1 changed file with 3 additions and 8 deletions.
11 changes: 3 additions & 8 deletions net/bluetooth/hci_core.c
Original file line number Diff line number Diff line change
Expand Up @@ -955,14 +955,9 @@ static ssize_t le_auto_conn_write(struct file *file, const char __user *data,
if (count < 3)
return -EINVAL;

buf = kzalloc(count, GFP_KERNEL);
if (!buf)
return -ENOMEM;

if (copy_from_user(buf, data, count)) {
err = -EFAULT;
goto done;
}
buf = memdup_user(data, count);
if (IS_ERR(buf))
return PTR_ERR(buf);

if (memcmp(buf, "add", 3) == 0) {
n = sscanf(&buf[4], "%hhx:%hhx:%hhx:%hhx:%hhx:%hhx %hhu %hhu",
Expand Down

0 comments on commit 4408dd1

Please sign in to comment.