Skip to content

Commit

Permalink
selinux: allow dontauditx and auditallowx rules to take effect withou…
Browse files Browse the repository at this point in the history
…t allowx

This allows for dontauditing very specific ioctls e.g. TCGETS without
dontauditing every ioctl or granting additional permissions.

Now either an allowx, dontauditx or auditallowx rules enables checking
for extended permissions.

Signed-off-by: Jonathan Hettwer <j2468h@gmail.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
  • Loading branch information
bauen1 authored and Paul Moore committed Oct 28, 2020
1 parent 83370b3 commit 44141f5
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions security/selinux/ss/services.c
Original file line number Diff line number Diff line change
Expand Up @@ -596,9 +596,7 @@ void services_compute_xperms_drivers(
node->datum.u.xperms->driver);
}

/* If no ioctl commands are allowed, ignore auditallow and auditdeny */
if (node->key.specified & AVTAB_XPERMS_ALLOWED)
xperms->len = 1;
xperms->len = 1;
}

/*
Expand Down

0 comments on commit 44141f5

Please sign in to comment.