Skip to content

Commit

Permalink
... and fold the renamed __vfs_follow_link() into its only caller
Browse files Browse the repository at this point in the history
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
Al Viro committed Sep 10, 2013
1 parent 4aa3289 commit 443ed25
Showing 1 changed file with 14 additions and 24 deletions.
38 changes: 14 additions & 24 deletions fs/namei.c
Original file line number Diff line number Diff line change
Expand Up @@ -660,29 +660,6 @@ static __always_inline void set_root_rcu(struct nameidata *nd)
}
}

static __always_inline int __follow_link(struct nameidata *nd, const char *link)
{
int ret;

if (IS_ERR(link))
goto fail;

if (*link == '/') {
set_root(nd);
path_put(&nd->path);
nd->path = nd->root;
path_get(&nd->root);
nd->flags |= LOOKUP_JUMPED;
}
nd->inode = nd->path.dentry->d_inode;

ret = link_path_walk(link, nd);
return ret;
fail:
path_put(&nd->path);
return PTR_ERR(link);
}

static void path_put_conditional(struct path *path, struct nameidata *nd)
{
dput(path->dentry);
Expand Down Expand Up @@ -874,7 +851,20 @@ follow_link(struct path *link, struct nameidata *nd, void **p)
error = 0;
s = nd_get_link(nd);
if (s) {
error = __follow_link(nd, s);
if (unlikely(IS_ERR(s))) {
path_put(&nd->path);
put_link(nd, link, *p);
return PTR_ERR(s);
}
if (*s == '/') {
set_root(nd);
path_put(&nd->path);
nd->path = nd->root;
path_get(&nd->root);
nd->flags |= LOOKUP_JUMPED;
}
nd->inode = nd->path.dentry->d_inode;
error = link_path_walk(s, nd);
if (unlikely(error))
put_link(nd, link, *p);
}
Expand Down

0 comments on commit 443ed25

Please sign in to comment.