Skip to content

Commit

Permalink
vm_is_stack: use for_each_thread() rather then buggy while_each_thread()
Browse files Browse the repository at this point in the history
Aleksei hit the soft lockup during reading /proc/PID/smaps.  David
investigated the problem and suggested the right fix.

while_each_thread() is racy and should die, this patch updates
vm_is_stack().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reported-by: Aleksei Besogonov <alex.besogonov@gmail.com>
Tested-by: Aleksei Besogonov <alex.besogonov@gmail.com>
Suggested-by: David Rientjes <rientjes@google.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Aug 8, 2014
1 parent edcad25 commit 4449a51
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions mm/util.c
Original file line number Diff line number Diff line change
Expand Up @@ -183,17 +183,14 @@ pid_t vm_is_stack(struct task_struct *task,

if (in_group) {
struct task_struct *t;
rcu_read_lock();
if (!pid_alive(task))
goto done;

t = task;
do {
rcu_read_lock();
for_each_thread(task, t) {
if (vm_is_stack_for_task(t, vma)) {
ret = t->pid;
goto done;
}
} while_each_thread(task, t);
}
done:
rcu_read_unlock();
}
Expand Down

0 comments on commit 4449a51

Please sign in to comment.