Skip to content

Commit

Permalink
drm/panel-edp: Add powered_on_to_enable delay
Browse files Browse the repository at this point in the history
Add the support of powered_on_to_enable delay as the minimum time that
needs to have passed between the panel powered on and enable may begin.

This delay is seen in BOE panels as the minimum delay of T3+T4+T5+T6+T8
in the eDP timing diagrams.

Signed-off-by: Pin-yen Lin <treapking@chromium.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20231214152817.2766280-2-treapking@chromium.org
  • Loading branch information
Pin-yen Lin authored and Douglas Anderson committed Dec 18, 2023
1 parent 3a63826 commit 4464af9
Showing 1 changed file with 20 additions and 0 deletions.
20 changes: 20 additions & 0 deletions drivers/gpu/drm/panel/panel-edp.c
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,21 @@ struct panel_delay {
*/
unsigned int hpd_absent;

/**
* @powered_on_to_enable: Time between panel powered on and enable.
*
* The minimum time, in milliseconds, that needs to have passed
* between when panel powered on and enable may begin.
*
* This is (T3+T4+T5+T6+T8)-min on eDP timing diagrams or after the
* power supply enabled until we can turn the backlight on and see
* valid data.
*
* This doesn't normally need to be set if timings are already met by
* prepare_to_enable or enable.
*/
unsigned int powered_on_to_enable;

/**
* @prepare_to_enable: Time between prepare and enable.
*
Expand Down Expand Up @@ -216,6 +231,7 @@ struct panel_edp {
bool prepared;

ktime_t prepared_time;
ktime_t powered_on_time;
ktime_t unprepared_time;

const struct panel_desc *desc;
Expand Down Expand Up @@ -455,6 +471,8 @@ static int panel_edp_prepare_once(struct panel_edp *p)

gpiod_set_value_cansleep(p->enable_gpio, 1);

p->powered_on_time = ktime_get_boottime();

delay = p->desc->delay.hpd_reliable;
if (p->no_hpd)
delay = max(delay, p->desc->delay.hpd_absent);
Expand Down Expand Up @@ -579,6 +597,8 @@ static int panel_edp_enable(struct drm_panel *panel)

panel_edp_wait(p->prepared_time, p->desc->delay.prepare_to_enable);

panel_edp_wait(p->powered_on_time, p->desc->delay.powered_on_to_enable);

p->enabled = true;

return 0;
Expand Down

0 comments on commit 4464af9

Please sign in to comment.