Skip to content

Commit

Permalink
ALSA: HDA: Fix sound resume hang
Browse files Browse the repository at this point in the history
Resuming a switcheroo'd HDA controller hangs since the completion
is one-shot (thus works the first time). Fix by using completions
that explictly need rearming, so remain fired before.

Signed-off-by: Daniel J Blueman <daniel@quora.org>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Daniel J Blueman authored and Takashi Iwai committed Dec 18, 2012
1 parent 6ffe168 commit 44728e9
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions sound/pci/hda/hda_intel.c
Original file line number Diff line number Diff line change
Expand Up @@ -2876,7 +2876,7 @@ static int azx_free(struct azx *chip)
azx_notifier_unregister(chip);

chip->init_failed = 1; /* to be sure */
complete(&chip->probe_wait);
complete_all(&chip->probe_wait);

if (use_vga_switcheroo(chip)) {
if (chip->disabled && chip->bus)
Expand Down Expand Up @@ -3504,7 +3504,7 @@ static int azx_probe(struct pci_dev *pci,
pm_runtime_put_noidle(&pci->dev);

dev++;
complete(&chip->probe_wait);
complete_all(&chip->probe_wait);
return 0;

out_free:
Expand Down

0 comments on commit 44728e9

Please sign in to comment.