Skip to content

Commit

Permalink
Revert "r8169: use netif_receive_skb_list batching"
Browse files Browse the repository at this point in the history
This reverts commit 6578229.
netif_receive_skb_list() doesn't support GRO, therefore we may have
scenarios with decreased performance. See discussion here [0].

[0] https://marc.info/?t=155403847400001&r=1&w=2

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Heiner Kallweit authored and David S. Miller committed Apr 5, 2019
1 parent f6fee16 commit 448a241
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions drivers/net/ethernet/realtek/r8169.c
Original file line number Diff line number Diff line change
Expand Up @@ -6426,7 +6426,6 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget
{
unsigned int cur_rx, rx_left;
unsigned int count;
LIST_HEAD(rx_list);

cur_rx = tp->cur_rx;

Expand Down Expand Up @@ -6502,7 +6501,7 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget
if (skb->pkt_type == PACKET_MULTICAST)
dev->stats.multicast++;

list_add_tail(&skb->list, &rx_list);
napi_gro_receive(&tp->napi, skb);

u64_stats_update_begin(&tp->rx_stats.syncp);
tp->rx_stats.packets++;
Expand All @@ -6517,8 +6516,6 @@ static int rtl_rx(struct net_device *dev, struct rtl8169_private *tp, u32 budget
count = cur_rx - tp->cur_rx;
tp->cur_rx = cur_rx;

netif_receive_skb_list(&rx_list);

return count;
}

Expand Down

0 comments on commit 448a241

Please sign in to comment.