Skip to content

Commit

Permalink
interconnect: icc-clk: check return values of devm_kasprintf()
Browse files Browse the repository at this point in the history
devm_kasprintf() can fail and return NULL, add missing return value
checks.

Fixes: 0ac2a08 ("interconnect: add clk-based icc provider support")
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://lore.kernel.org/r/20241202165723.17292-1-brgl@bgdev.pl
Signed-off-by: Georgi Djakov <djakov@kernel.org>
  • Loading branch information
Bartosz Golaszewski authored and Georgi Djakov committed Dec 17, 2024
1 parent 00a973e commit 44c5aa7
Showing 1 changed file with 10 additions and 0 deletions.
10 changes: 10 additions & 0 deletions drivers/interconnect/icc-clk.c
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,11 @@ struct icc_provider *icc_clk_register(struct device *dev,
}

node->name = devm_kasprintf(dev, GFP_KERNEL, "%s_master", data[i].name);
if (!node->name) {
ret = -ENOMEM;
goto err;
}

node->data = &qp->clocks[i];
icc_node_add(node, provider);
/* link to the next node, slave */
Expand All @@ -129,6 +134,11 @@ struct icc_provider *icc_clk_register(struct device *dev,
}

node->name = devm_kasprintf(dev, GFP_KERNEL, "%s_slave", data[i].name);
if (!node->name) {
ret = -ENOMEM;
goto err;
}

/* no data for slave node */
icc_node_add(node, provider);
onecell->nodes[j++] = node;
Expand Down

0 comments on commit 44c5aa7

Please sign in to comment.