Skip to content

Commit

Permalink
block: default BLOCK_LEGACY_AUTOLOAD to y
Browse files Browse the repository at this point in the history
As Luis reported, losetup currently doesn't properly create the loop
device without this if the device node already exists because old
scripts created it manually.  So default to y for now and remove the
aggressive removal schedule.

Reported-by: Luis Chamberlain <mcgrof@kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Link: https://lore.kernel.org/r/20220225181440.1351591-1-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Christoph Hellwig authored and Jens Axboe committed Feb 27, 2022
1 parent 86d7331 commit 451f0b6
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
8 changes: 3 additions & 5 deletions block/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -28,15 +28,13 @@ if BLOCK

config BLOCK_LEGACY_AUTOLOAD
bool "Legacy autoloading support"
default y
help
Enable loading modules and creating block device instances based on
accesses through their device special file. This is a historic Linux
feature and makes no sense in a udev world where device files are
created on demand.

Say N here unless booting or other functionality broke without it, in
which case you should also send a report to your distribution and
linux-block@vger.kernel.org.
created on demand, but scripts that manually create device nodes and
then call losetup might rely on this behavior.

config BLK_RQ_ALLOC_TIME
bool
Expand Down
2 changes: 1 addition & 1 deletion block/bdev.c
Original file line number Diff line number Diff line change
Expand Up @@ -738,7 +738,7 @@ struct block_device *blkdev_get_no_open(dev_t dev)
inode = ilookup(blockdev_superblock, dev);
if (inode)
pr_warn_ratelimited(
"block device autoloading is deprecated. It will be removed in Linux 5.19\n");
"block device autoloading is deprecated and will be removed.\n");
}
if (!inode)
return NULL;
Expand Down

0 comments on commit 451f0b6

Please sign in to comment.