Skip to content

Commit

Permalink
dt-bindings: Remove FIXME in yaml bindings
Browse files Browse the repository at this point in the history
Some binding that were introduced early on got a comment to enable
additionalProperties, but we couldn't due to the generic properties being
reported as errors.

The way we're dealing with this now is to use the draft-08's
unevaluatedProperties (even though the tools doesn't do anything with it
yet).

Let's convert those old bindings to it.

Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Signed-off-by: Rob Herring <robh@kernel.org>
  • Loading branch information
Maxime Ripard authored and Rob Herring committed Nov 6, 2019
1 parent 07e6315 commit 454f5d9
Show file tree
Hide file tree
Showing 11 changed files with 16 additions and 38 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,7 @@ else:
clocks:
maxItems: 1

# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false
unevaluatedProperties: false

examples:
- |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,9 +40,7 @@ required:
- clocks
- resets

# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false
unevaluatedProperties: false

examples:
- |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,9 +93,7 @@ allOf:
required:
- resets

# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false
unevaluatedProperties: false

examples:
- |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,9 +52,7 @@ required:
- interrupts
- interrupt-controller

# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false
unevaluatedProperties: false

examples:
- |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,9 +60,7 @@ required:
- clocks
- clock-names

# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false
unevaluatedProperties: false

examples:
- |
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,8 @@ required:
- clocks
- clock-names

unevaluatedProperties: false

examples:
- |
mmc0: mmc@1c0f000 {
Expand All @@ -97,8 +99,4 @@ examples:
cd-gpios = <&pio 7 1 0>;
};
# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false

...
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,8 @@ required:
- phy-handle
- allwinner,sram

unevaluatedProperties: false

examples:
- |
emac: ethernet@1c0b000 {
Expand All @@ -49,8 +51,4 @@ examples:
allwinner,sram = <&emac_sram 1>;
};
# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false

...
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ required:
- compatible
- reg

unevaluatedProperties: false

examples:
- |
mdio@1c0b080 {
Expand All @@ -63,8 +65,4 @@ examples:
};
};
# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false

...
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ required:
- clock-names
- phy-mode

unevaluatedProperties: false

examples:
- |
gmac: ethernet@1c50000 {
Expand All @@ -61,8 +63,4 @@ examples:
phy-mode = "mii";
};
# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false

...
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ allOf:
- mdio-parent-bus
- mdio@1

unevaluatedProperties: false

examples:
- |
ethernet@1c0b000 {
Expand Down Expand Up @@ -314,8 +316,4 @@ examples:
};
};
# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false

...
Original file line number Diff line number Diff line change
Expand Up @@ -31,9 +31,7 @@ required:
- compatible
- reg

# FIXME: We should set it, but it would report all the generic
# properties as additional properties.
# additionalProperties: false
unevaluatedProperties: false

examples:
- |
Expand Down

0 comments on commit 454f5d9

Please sign in to comment.