Skip to content

Commit

Permalink
mm/slab_common.c: cleanup
Browse files Browse the repository at this point in the history
Eliminate an ifdef and a label by moving all the CONFIG_DEBUG_VM checking
inside the locked region.

Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
  • Loading branch information
Andrew Morton authored and Pekka Enberg committed Aug 16, 2012
1 parent 48f2474 commit 455ce9e
Showing 1 changed file with 5 additions and 10 deletions.
15 changes: 5 additions & 10 deletions mm/slab_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -53,19 +53,17 @@ struct kmem_cache *kmem_cache_create(const char *name, size_t size, size_t align
{
struct kmem_cache *s = NULL;

get_online_cpus();
mutex_lock(&slab_mutex);

#ifdef CONFIG_DEBUG_VM
if (!name || in_interrupt() || size < sizeof(void *) ||
size > KMALLOC_MAX_SIZE) {
printk(KERN_ERR "kmem_cache_create(%s) integrity check"
" failed\n", name);
goto out;
" failed\n", name);
goto oops;
}
#endif

get_online_cpus();
mutex_lock(&slab_mutex);

#ifdef CONFIG_DEBUG_VM
list_for_each_entry(s, &slab_caches, list) {
char tmp;
int res;
Expand Down Expand Up @@ -104,9 +102,6 @@ struct kmem_cache *kmem_cache_create(const char *name, size_t size, size_t align
mutex_unlock(&slab_mutex);
put_online_cpus();

#ifdef CONFIG_DEBUG_VM
out:
#endif
if (!s && (flags & SLAB_PANIC))
panic("kmem_cache_create: Failed to create slab '%s'\n", name);

Expand Down

0 comments on commit 455ce9e

Please sign in to comment.