Skip to content

Commit

Permalink
uprobes/tracing: Kill the pointless seq_print_ip_sym() call
Browse files Browse the repository at this point in the history
seq_print_ip_sym(ip) in print_uprobe_event() is pointless,
kallsyms_lookup(ip) can not resolve a user-space address.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Tested-by: Anton Arapov <anton@redhat.com>
  • Loading branch information
Oleg Nesterov committed Apr 13, 2013
1 parent 07720b6 commit 456fdbc
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions kernel/trace/trace_uprobe.c
Original file line number Diff line number Diff line change
Expand Up @@ -531,13 +531,7 @@ print_uprobe_event(struct trace_iterator *iter, int flags, struct trace_event *e
field = (struct uprobe_trace_entry_head *)iter->ent;
tu = container_of(event, struct trace_uprobe, call.event);

if (!trace_seq_printf(s, "%s: (", tu->call.name))
goto partial;

if (!seq_print_ip_sym(s, field->ip, flags | TRACE_ITER_SYM_OFFSET))
goto partial;

if (!trace_seq_puts(s, ")"))
if (!trace_seq_printf(s, "%s: (0x%lx)", tu->call.name, field->ip))
goto partial;

data = (u8 *)&field[1];
Expand Down

0 comments on commit 456fdbc

Please sign in to comment.