Skip to content

Commit

Permalink
net: macsec: Add endianness annotations in salt struct
Browse files Browse the repository at this point in the history
This change resolves warning produced by sparse tool as currently
there is a mismatch between normal generic type in salt and endian
annotated type in macsec driver code. Endian annotated types should
be used here.

Sparse output:
warning: restricted ssci_t degrades to integer
warning: incorrect type in assignment (different base types)
    expected restricted ssci_t [usertype] ssci
    got unsigned int
warning: restricted __be64 degrades to integer
warning: incorrect type in assignment (different base types)
    expected restricted __be64 [usertype] pn
    got unsigned long long

Signed-off-by: Ales Nezbeda <anezbeda@redhat.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Sabrina Dubroca <sd@queasysnail.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ales Nezbeda authored and David S. Miller committed Jan 20, 2025
1 parent 5fe71fd commit 457bb79
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions include/net/macsec.h
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ struct metadata_dst;

typedef union salt {
struct {
u32 ssci;
u64 pn;
ssci_t ssci;
__be64 pn;
} __packed;
u8 bytes[MACSEC_SALT_LEN];
} __packed salt_t;
Expand Down

0 comments on commit 457bb79

Please sign in to comment.