Skip to content

Commit

Permalink
xen-netfront: Update features after registering netdev
Browse files Browse the repository at this point in the history
Update the features after calling register_netdev() otherwise the
device features are not set up correctly and it not possible to change
the MTU of the device. After this change, the features reported by
ethtool match the device's features before the commit which introduced
the issue and it is possible to change the device's MTU.

Fixes: f599c64 ("xen-netfront: Fix race between device setup and open")
Reported-by: Liam Shepherd <liam@dancer.es>
Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ross Lagerwall authored and David S. Miller committed Jun 21, 2018
1 parent cb25778 commit 45c8184
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/xen-netfront.c
Original file line number Diff line number Diff line change
Expand Up @@ -1951,10 +1951,6 @@ static int xennet_connect(struct net_device *dev)
/* talk_to_netback() sets the correct number of queues */
num_queues = dev->real_num_tx_queues;

rtnl_lock();
netdev_update_features(dev);
rtnl_unlock();

if (dev->reg_state == NETREG_UNINITIALIZED) {
err = register_netdev(dev);
if (err) {
Expand All @@ -1964,6 +1960,10 @@ static int xennet_connect(struct net_device *dev)
}
}

rtnl_lock();
netdev_update_features(dev);
rtnl_unlock();

/*
* All public and private state should now be sane. Get
* ready to start sending and receiving packets and give the driver
Expand Down

0 comments on commit 45c8184

Please sign in to comment.