Skip to content

Commit

Permalink
powerpc/spufs: Remove double check for non-negative dentry
Browse files Browse the repository at this point in the history
This patch removes an unnecessary double check if the dentry returned by
lookup_create() is actually non-negative. Since lookup_create() itself returns
an error in this case just remove the check.

Signed-off-by: Jan Blunck <jblunck@suse.de>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
  • Loading branch information
Jan Blunck authored and Benjamin Herrenschmidt committed May 21, 2009
1 parent 8d165db commit 45db924
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions arch/powerpc/platforms/cell/spufs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -631,10 +631,6 @@ long spufs_create(struct nameidata *nd, unsigned int flags, mode_t mode,
if (IS_ERR(dentry))
goto out_dir;

ret = -EEXIST;
if (dentry->d_inode)
goto out_dput;

mode &= ~current_umask();

if (flags & SPU_CREATE_GANG)
Expand Down

0 comments on commit 45db924

Please sign in to comment.