Skip to content

Commit

Permalink
rcu: Make rcu_gp_init() be bool rather than int
Browse files Browse the repository at this point in the history
The return value from rcu_gp_init() is always used as a bool, so
this commit makes it be a bool.

Reported-by: Iftekhar Ahmed <ahmedi@oregonstate.edu>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
  • Loading branch information
Paul E. McKenney committed Dec 8, 2015
1 parent e11f133 commit 45fed3e
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions kernel/rcu/tree.c
Original file line number Diff line number Diff line change
Expand Up @@ -1814,9 +1814,9 @@ static void rcu_gp_slow(struct rcu_state *rsp, int delay)
}

/*
* Initialize a new grace period. Return 0 if no grace period required.
* Initialize a new grace period. Return false if no grace period required.
*/
static int rcu_gp_init(struct rcu_state *rsp)
static bool rcu_gp_init(struct rcu_state *rsp)
{
unsigned long oldmask;
struct rcu_data *rdp;
Expand All @@ -1827,7 +1827,7 @@ static int rcu_gp_init(struct rcu_state *rsp)
if (!READ_ONCE(rsp->gp_flags)) {
/* Spurious wakeup, tell caller to go back to sleep. */
raw_spin_unlock_irq(&rnp->lock);
return 0;
return false;
}
WRITE_ONCE(rsp->gp_flags, 0); /* Clear all flags: New grace period. */

Expand All @@ -1837,7 +1837,7 @@ static int rcu_gp_init(struct rcu_state *rsp)
* Not supposed to be able to happen.
*/
raw_spin_unlock_irq(&rnp->lock);
return 0;
return false;
}

/* Advance to a new grace period and initialize state. */
Expand Down Expand Up @@ -1929,7 +1929,7 @@ static int rcu_gp_init(struct rcu_state *rsp)
WRITE_ONCE(rsp->gp_activity, jiffies);
}

return 1;
return true;
}

/*
Expand Down

0 comments on commit 45fed3e

Please sign in to comment.