Skip to content

Commit

Permalink
tools lib api fs: Replace debugfs/tracefs objects interface with fs.c
Browse files Browse the repository at this point in the history
Switching to the fs.c related filesystem framework.

Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Raphael Beamonte <raphael.beamonte@gmail.com>
Cc: Steven Rostedt <rostedt@goodmis.org>
Link: http://lkml.kernel.org/r/1441180605-24737-14-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Jiri Olsa authored and Arnaldo Carvalho de Melo committed Sep 14, 2015
1 parent 4f234f0 commit 4605eab
Show file tree
Hide file tree
Showing 11 changed files with 23 additions and 29 deletions.
1 change: 0 additions & 1 deletion tools/lib/api/fs/fs.c
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
#include <unistd.h>
#include <sys/mount.h>

#include "debugfs.h"
#include "fs.h"

#define _STR(x) #x
Expand Down
15 changes: 7 additions & 8 deletions tools/lib/api/fs/tracing_path.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@
#include <string.h>
#include <errno.h>
#include <unistd.h>
#include "debugfs.h"
#include "tracefs.h"
#include "fs.h"

#include "tracing_path.h"

Expand All @@ -29,7 +28,7 @@ static const char *tracing_path_tracefs_mount(void)
{
const char *mnt;

mnt = tracefs_mount(NULL);
mnt = tracefs__mount();
if (!mnt)
return NULL;

Expand All @@ -42,7 +41,7 @@ static const char *tracing_path_debugfs_mount(void)
{
const char *mnt;

mnt = debugfs_mount(NULL);
mnt = debugfs__mount();
if (!mnt)
return NULL;

Expand Down Expand Up @@ -96,7 +95,7 @@ static int strerror_open(int err, char *buf, size_t size, const char *filename)
* want some tracepoint which wasn't compiled in your kernel.
* - jirka
*/
if (debugfs_configured() || tracefs_configured()) {
if (debugfs__configured() || tracefs__configured()) {
snprintf(buf, size,
"Error:\tFile %s/%s not found.\n"
"Hint:\tPerhaps this kernel misses some CONFIG_ setting to enable this feature?.\n",
Expand All @@ -110,13 +109,13 @@ static int strerror_open(int err, char *buf, size_t size, const char *filename)
"Hint:\tTry 'sudo mount -t debugfs nodev /sys/kernel/debug'");
break;
case EACCES: {
const char *mountpoint = debugfs_find_mountpoint();
const char *mountpoint = debugfs__mountpoint();

if (!access(mountpoint, R_OK) && strncmp(filename, "tracing/", 8) == 0) {
const char *tracefs_mntpoint = tracefs_find_mountpoint();
const char *tracefs_mntpoint = tracefs__mountpoint();

if (tracefs_mntpoint)
mountpoint = tracefs_find_mountpoint();
mountpoint = tracefs__mountpoint();
}

snprintf(buf, size,
Expand Down
1 change: 0 additions & 1 deletion tools/perf/builtin-kvm.c
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
#include "util/parse-options.h"
#include "util/trace-event.h"
#include "util/debug.h"
#include <api/fs/debugfs.h>
#include "util/tool.h"
#include "util/stat.h"
#include "util/top.h"
Expand Down
1 change: 0 additions & 1 deletion tools/perf/builtin-probe.c
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@
#include "util/strfilter.h"
#include "util/symbol.h"
#include "util/debug.h"
#include <api/fs/debugfs.h>
#include "util/parse-options.h"
#include "util/probe-finder.h"
#include "util/probe-event.h"
Expand Down
5 changes: 3 additions & 2 deletions tools/perf/tests/openat-syscall-all-cpus.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#include <api/fs/fs.h>
#include "evsel.h"
#include "tests.h"
#include "thread_map.h"
Expand Down Expand Up @@ -30,9 +31,9 @@ int test__openat_syscall_event_on_all_cpus(void)

evsel = perf_evsel__newtp("syscalls", "sys_enter_openat");
if (evsel == NULL) {
if (tracefs_configured())
if (tracefs__configured())
pr_debug("is tracefs mounted on /sys/kernel/tracing?\n");
else if (debugfs_configured())
else if (debugfs__configured())
pr_debug("is debugfs mounted on /sys/kernel/debug?\n");
else
pr_debug("Neither tracefs or debugfs is enabled in this kernel\n");
Expand Down
5 changes: 3 additions & 2 deletions tools/perf/tests/openat-syscall.c
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
#include <api/fs/fs.h>
#include "thread_map.h"
#include "evsel.h"
#include "debug.h"
Expand All @@ -18,9 +19,9 @@ int test__openat_syscall_event(void)

evsel = perf_evsel__newtp("syscalls", "sys_enter_openat");
if (evsel == NULL) {
if (tracefs_configured())
if (tracefs__configured())
pr_debug("is tracefs mounted on /sys/kernel/tracing?\n");
else if (debugfs_configured())
else if (debugfs__configured())
pr_debug("is debugfs mounted on /sys/kernel/debug?\n");
else
pr_debug("Neither tracefs or debugfs is enabled in this kernel\n");
Expand Down
7 changes: 3 additions & 4 deletions tools/perf/tests/parse-events.c
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,10 @@
#include "evsel.h"
#include "evlist.h"
#include <api/fs/fs.h>
#include <api/fs/tracefs.h>
#include <api/fs/debugfs.h>
#include "tests.h"
#include "debug.h"
#include <linux/hw_breakpoint.h>
#include <api/fs/fs.h>

#define PERF_TP_SAMPLE_TYPE (PERF_SAMPLE_RAW | PERF_SAMPLE_TIME | \
PERF_SAMPLE_CPU | PERF_SAMPLE_PERIOD)
Expand Down Expand Up @@ -1268,12 +1267,12 @@ static int count_tracepoints(void)
DIR *events_dir;
int cnt = 0;

mountpoint = tracefs_find_mountpoint();
mountpoint = tracefs__mountpoint();
if (mountpoint) {
scnprintf(events_path, PATH_MAX, "%s/events",
mountpoint);
} else {
mountpoint = debugfs_find_mountpoint();
mountpoint = debugfs__mountpoint();
scnprintf(events_path, PATH_MAX, "%s/tracing/events",
mountpoint);
}
Expand Down
2 changes: 1 addition & 1 deletion tools/perf/util/evsel.c
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@

#include <byteswap.h>
#include <linux/bitops.h>
#include <api/fs/debugfs.h>
#include <api/fs/tracing_path.h>
#include <traceevent/event-parse.h>
#include <linux/hw_breakpoint.h>
#include <linux/perf_event.h>
Expand Down
5 changes: 2 additions & 3 deletions tools/perf/util/probe-event.c
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,7 @@
#include "color.h"
#include "symbol.h"
#include "thread.h"
#include <api/fs/debugfs.h>
#include <api/fs/tracefs.h>
#include <api/fs/fs.h>
#include "trace-event.h" /* For __maybe_unused */
#include "probe-event.h"
#include "probe-finder.h"
Expand Down Expand Up @@ -2054,7 +2053,7 @@ static void kprobe_blacklist__delete(struct list_head *blacklist)
static int kprobe_blacklist__load(struct list_head *blacklist)
{
struct kprobe_blacklist_node *node;
const char *__debugfs = debugfs_find_mountpoint();
const char *__debugfs = debugfs__mountpoint();
char buf[PATH_MAX], *p;
FILE *fp;
int ret;
Expand Down
7 changes: 3 additions & 4 deletions tools/perf/util/probe-file.c
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,7 @@
#include "color.h"
#include "symbol.h"
#include "thread.h"
#include <api/fs/debugfs.h>
#include <api/fs/tracefs.h>
#include <api/fs/fs.h>
#include "probe-event.h"
#include "probe-file.h"
#include "session.h"
Expand Down Expand Up @@ -77,11 +76,11 @@ static int open_probe_events(const char *trace_file, bool readwrite)
const char *tracing_dir = "";
int ret;

__debugfs = tracefs_find_mountpoint();
__debugfs = tracefs__mountpoint();
if (__debugfs == NULL) {
tracing_dir = "tracing/";

__debugfs = debugfs_find_mountpoint();
__debugfs = debugfs__mountpoint();
if (__debugfs == NULL)
return -ENOTSUP;
}
Expand Down
3 changes: 1 addition & 2 deletions tools/perf/util/util.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@
#include <linux/magic.h>
#include <linux/types.h>
#include <sys/ttydefaults.h>
#include <api/fs/debugfs.h>
#include <api/fs/tracefs.h>
#include <api/fs/tracing_path.h>
#include <termios.h>
#include <linux/bitops.h>
#include <termios.h>
Expand Down

0 comments on commit 4605eab

Please sign in to comment.