Skip to content

Commit

Permalink
Fix non TBI PHY access; a bad merge undid bug fix in a previous commit.
Browse files Browse the repository at this point in the history
The merge done in commit b26e478 undid bug fix in commit c3e072f
("net: fsl_pq_mdio: fix non tbi phy access"), with the result that non
TBI (e.g. MDIO) PHYs cannot be accessed.

Signed-off-by: Kenth Eriksson <kenth.eriksson@transmode.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Kenth Eriksson authored and David S. Miller committed Apr 1, 2012
1 parent 6737856 commit 464b57d
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions drivers/net/ethernet/freescale/fsl_pq_mdio.c
Original file line number Diff line number Diff line change
Expand Up @@ -356,13 +356,13 @@ static int fsl_pq_mdio_probe(struct platform_device *ofdev)

if (prop)
tbiaddr = *prop;
}

if (tbiaddr == -1) {
err = -EBUSY;
goto err_free_irqs;
} else {
out_be32(tbipa, tbiaddr);
if (tbiaddr == -1) {
err = -EBUSY;
goto err_free_irqs;
} else {
out_be32(tbipa, tbiaddr);
}
}

err = of_mdiobus_register(new_bus, np);
Expand Down

0 comments on commit 464b57d

Please sign in to comment.