Skip to content

Commit

Permalink
ARM: dts: rockchip: correct regulator power states for suspend
Browse files Browse the repository at this point in the history
When getting translated from a downstream device tree that used slightly
different DT bindings, these regulators got labeled with the
"on-in-suspend" state, when they were actually supposed to be turned off
for S3 suspend. This was harmless, but not intentional, AFAICT.

Let's turn them off to get the optimal power state.

Signed-off-by: Brian Norris <briannorris@chromium.org>
Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
  • Loading branch information
Brian Norris authored and Heiko Stuebner committed Aug 20, 2015
1 parent 6a414e4 commit 467fb18
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/rk3288-veyron-jerry.dts
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <1800000>;
regulator-state-mem {
regulator-on-in-suspend;
regulator-off-in-suspend;
};
};
};
Expand Down
2 changes: 1 addition & 1 deletion arch/arm/boot/dts/rk3288-veyron-pinky.dts
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@
regulator-boot-on;
regulator-name = "vcc18_lcd";
regulator-state-mem {
regulator-on-in-suspend;
regulator-off-in-suspend;
};
};
};
Expand Down
4 changes: 2 additions & 2 deletions arch/arm/boot/dts/rk3288-veyron-sdmmc.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
regulator-state-mem {
regulator-on-in-suspend;
regulator-off-in-suspend;
};
};

Expand All @@ -102,7 +102,7 @@
regulator-min-microvolt = <3300000>;
regulator-max-microvolt = <3300000>;
regulator-state-mem {
regulator-on-in-suspend;
regulator-off-in-suspend;
};
};
};
Expand Down

0 comments on commit 467fb18

Please sign in to comment.