Skip to content

Commit

Permalink
[SCSI] qla4xxx: Proper detection of firmware abort error code for ISP…
Browse files Browse the repository at this point in the history
…82xx

Signed-off-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>
  • Loading branch information
Vikas Chaudhary authored and James Bottomley committed Feb 19, 2012
1 parent badc5b9 commit 46801ba
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions drivers/scsi/qla4xxx/ql4_def.h
Original file line number Diff line number Diff line change
Expand Up @@ -150,8 +150,6 @@
#define QL4_SESS_RECOVERY_TMO 120 /* iSCSI session */
/* recovery timeout */

#define MSB(x) ((uint8_t)((uint16_t)(x) >> 8))
#define LSW(x) ((uint16_t)(x))
#define LSDW(x) ((u32)((u64)(x)))
#define MSDW(x) ((u32)((((u64)(x)) >> 16) >> 16))

Expand Down
1 change: 1 addition & 0 deletions drivers/scsi/qla4xxx/ql4_nx.h
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,7 @@ struct crb_addr_pair {

#define ADDR_ERROR ((unsigned long) 0xffffffff)
#define MAX_CTL_CHECK 1000
#define QLA82XX_FWERROR_CODE(code) ((code >> 8) & 0x1fffff)

/***************************************************************************
* PCI related defines.
Expand Down
2 changes: 1 addition & 1 deletion drivers/scsi/qla4xxx/ql4_os.c
Original file line number Diff line number Diff line change
Expand Up @@ -2165,7 +2165,7 @@ void qla4_8xxx_watchdog(struct scsi_qla_host *ha)
halt_status = qla4_8xxx_rd_32(ha,
QLA82XX_PEG_HALT_STATUS1);

if (LSW(MSB(halt_status)) == 0x67)
if (QLA82XX_FWERROR_CODE(halt_status) == 0x67)
ql4_printk(KERN_ERR, ha, "%s:"
" Firmware aborted with"
" error code 0x00006700."
Expand Down

0 comments on commit 46801ba

Please sign in to comment.