Skip to content

Commit

Permalink
irqchip/atmel-aic: Fix unbalanced of_node_put() in aic_common_irq_fix…
Browse files Browse the repository at this point in the history
…up()

aic_common_irq_fixup() is calling twice of_node_put() on the same node
thus leading to an unbalanced refcount on the root node.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Reported-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Fixes: b2f579b ("irqchip: atmel-aic: Add irq fixup infrastructure")
Cc: <stable@vger.kernel.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
  • Loading branch information
Boris Brezillon authored and Marc Zyngier committed Jul 4, 2017
1 parent ca38701 commit 469bcef
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/irqchip/irq-atmel-aic-common.c
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,6 @@ static void __init aic_common_irq_fixup(const struct of_device_id *matches)
return;

match = of_match_node(matches, root);
of_node_put(root);

if (match) {
void (*fixup)(struct device_node *) = match->data;
Expand Down

0 comments on commit 469bcef

Please sign in to comment.