Skip to content

Commit

Permalink
netlink: Fix do_one_broadcast() prototype.
Browse files Browse the repository at this point in the history
This patch changes the prototype of the do_one_broadcast() method so that it will return void.

Signed-off-by: Rami Rosen <ramirose@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Rami Rosen authored and David S. Miller committed Jul 8, 2014
1 parent 8e6e85e commit 46c9521
Showing 1 changed file with 6 additions and 9 deletions.
15 changes: 6 additions & 9 deletions net/netlink/af_netlink.c
Original file line number Diff line number Diff line change
Expand Up @@ -1961,25 +1961,25 @@ struct netlink_broadcast_data {
void *tx_data;
};

static int do_one_broadcast(struct sock *sk,
struct netlink_broadcast_data *p)
static void do_one_broadcast(struct sock *sk,
struct netlink_broadcast_data *p)
{
struct netlink_sock *nlk = nlk_sk(sk);
int val;

if (p->exclude_sk == sk)
goto out;
return;

if (nlk->portid == p->portid || p->group - 1 >= nlk->ngroups ||
!test_bit(p->group - 1, nlk->groups))
goto out;
return;

if (!net_eq(sock_net(sk), p->net))
goto out;
return;

if (p->failure) {
netlink_overrun(sk);
goto out;
return;
}

sock_hold(sk);
Expand Down Expand Up @@ -2017,9 +2017,6 @@ static int do_one_broadcast(struct sock *sk,
p->skb2 = NULL;
}
sock_put(sk);

out:
return 0;
}

int netlink_broadcast_filtered(struct sock *ssk, struct sk_buff *skb, u32 portid,
Expand Down

0 comments on commit 46c9521

Please sign in to comment.