Skip to content

Commit

Permalink
net: phy: fix sparse warning in fixed.c
Browse files Browse the repository at this point in the history
This commit fixes the following sparse warning:

drivers/net/phy/fixed.c:207
    - warning: symbol 'fixed_phy_del' was not declared.
      Should it be static?

by adding symbol definition to the phy_fixed.h API file. It is ok to do
because the function in question is an exported symbol.

Signed-off-by: Konrad Zapalowicz <bergo.torino@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Konrad Zapalowicz authored and David S. Miller committed Jun 5, 2014
1 parent 9a8d4d1 commit 46cfd6e
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions include/linux/phy_fixed.h
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ extern int fixed_phy_add(unsigned int irq, int phy_id,
extern int fixed_phy_register(unsigned int irq,
struct fixed_phy_status *status,
struct device_node *np);
extern void fixed_phy_del(int phy_addr);
#else
static inline int fixed_phy_add(unsigned int irq, int phy_id,
struct fixed_phy_status *status)
Expand All @@ -29,6 +30,10 @@ static inline int fixed_phy_register(unsigned int irq,
{
return -ENODEV;
}
static inline int fixed_phy_del(int phy_addr)
{
return -ENODEV;
}
#endif /* CONFIG_FIXED_PHY */

/*
Expand Down

0 comments on commit 46cfd6e

Please sign in to comment.