Skip to content

Commit

Permalink
arm64: dts: clearfog-gt-8k: set gigabit PHY reset deassert delay
Browse files Browse the repository at this point in the history
If the mv88e6xxx DSA driver is built as a module, it causes the
ethernet driver to re-probe when it's loaded. This in turn causes
the gigabit PHY to be momentarily reset and reprogrammed. However,
we attempt to reprogram the PHY immediately after deasserting reset,
and the PHY ignores the writes.

This results in the PHY operating in the wrong mode, and the copper
link states down.

Set a reset deassert delay of 10ms for the gigabit PHY to avoid this.

Fixes: babc554 ("arm64: dts: clearfog-gt-8k: 1G eth PHY reset signal")
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
  • Loading branch information
Russell King authored and Gregory CLEMENT committed Mar 13, 2020
1 parent bb6d3fb commit 46f94c7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions arch/arm64/boot/dts/marvell/armada-8040-clearfog-gt-8k.dts
Original file line number Diff line number Diff line change
Expand Up @@ -367,6 +367,7 @@
pinctrl-0 = <&cp0_copper_eth_phy_reset>;
reset-gpios = <&cp0_gpio2 11 GPIO_ACTIVE_LOW>;
reset-assert-us = <10000>;
reset-deassert-us = <10000>;
};

switch0: switch0@4 {
Expand Down

0 comments on commit 46f94c7

Please sign in to comment.