Skip to content

Commit

Permalink
drm/tegra: Don't call SET_APPLICATION_ID in VIC boot
Browse files Browse the repository at this point in the history
The application should be programming the application ID, not
the kernel, as there can be several options to choose from,
and setting the application ID multiple times can cause issues.

Signed-off-by: Mikko Perttunen <mperttunen@nvidia.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
  • Loading branch information
Mikko Perttunen authored and Thierry Reding committed Jun 11, 2021
1 parent d12919b commit 46f99ee
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions drivers/gpu/drm/tegra/vic.c
Original file line number Diff line number Diff line change
Expand Up @@ -148,8 +148,6 @@ static int vic_boot(struct vic *vic)
hdr = vic->falcon.firmware.virt;
fce_bin_data_offset = *(u32 *)(hdr + VIC_UCODE_FCE_DATA_OFFSET);

falcon_execute_method(&vic->falcon, VIC_SET_APPLICATION_ID, 1);

/* Old VIC firmware needs kernel help with setting up FCE microcode. */
if (fce_bin_data_offset != 0x0 && fce_bin_data_offset != 0xa5a5a5a5) {
hdr = vic->falcon.firmware.virt +
Expand Down
1 change: 0 additions & 1 deletion drivers/gpu/drm/tegra/vic.h
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

/* VIC methods */

#define VIC_SET_APPLICATION_ID 0x00000200
#define VIC_SET_FCE_UCODE_SIZE 0x0000071C
#define VIC_SET_FCE_UCODE_OFFSET 0x0000072C

Expand Down

0 comments on commit 46f99ee

Please sign in to comment.