Skip to content

Commit

Permalink
cifs: Add CONFIG_CIFS_DEBUG and rename use of CIFS_DEBUG
Browse files Browse the repository at this point in the history
This can reduce the size of the module by ~120KB which
could be useful for embedded systems.

$ size fs/cifs/built-in.o*
   text	   data	    bss	    dec	    hex	filename
 388567	  34459	 100440	 523466	  7fcca	fs/cifs/built-in.o.new
 495970	  34599	 117904	 648473	  9e519	fs/cifs/built-in.o.old

Signed-off-by: Joe Perches <joe@perches.com>
Reviewed-by: Jeff Layton <jlayton@redhat.com>
  • Loading branch information
Joe Perches authored and Steve French committed Dec 5, 2012
1 parent bde9819 commit 471b1f9
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 3 deletions.
10 changes: 9 additions & 1 deletion fs/cifs/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,17 @@ config CIFS_ACL
Allows fetching CIFS/NTFS ACL from the server. The DACL blob
is handed over to the application/caller.

config CIFS_DEBUG
bool "Enable CIFS debugging routines"
default y
depends on CIFS
help
Enabling this option adds helpful debugging messages to
the cifs code which increases the size of the cifs module.
If unsure, say Y.
config CIFS_DEBUG2
bool "Enable additional CIFS debugging routines"
depends on CIFS
depends on CIFS_DEBUG
help
Enabling this option adds a few more debugging routines
to the cifs code which slightly increases the size of
Expand Down
3 changes: 1 addition & 2 deletions fs/cifs/cifs_debug.h
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
* Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
*
*/
#define CIFS_DEBUG /* BB temporary */

#ifndef _H_CIFS_DEBUG
#define _H_CIFS_DEBUG
Expand All @@ -44,7 +43,7 @@ extern int cifsERROR;
* debug ON
* --------
*/
#ifdef CIFS_DEBUG
#ifdef CONFIG_CIFS_DEBUG

/* information message: e.g., configuration, major event */
#define cifsfyi(fmt, ...) \
Expand Down

0 comments on commit 471b1f9

Please sign in to comment.