Skip to content

Commit

Permalink
[media] videobuf2-dma-contig: make cookie() return a pointer to dma_a…
Browse files Browse the repository at this point in the history
…ddr_t

dma_addr_t may not fit into void* on some architectures. To be safe, make
vb2_dma_contig_cookie() return a pointer to dma_addr_t and dereference it
in vb2_dma_contig_plane_paddr() back to dma_addr_t.

Signed-off-by: Pawel Osciak <pawel@osciak.com>
Reported-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
  • Loading branch information
Pawel Osciak authored and Mauro Carvalho Chehab committed Mar 22, 2011
1 parent d6db5bf commit 472af2b
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
2 changes: 1 addition & 1 deletion drivers/media/video/videobuf2-dma-contig.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ static void *vb2_dma_contig_cookie(void *buf_priv)
{
struct vb2_dc_buf *buf = buf_priv;

return (void *)buf->paddr;
return &buf->paddr;
}

static void *vb2_dma_contig_vaddr(void *buf_priv)
Expand Down
9 changes: 6 additions & 3 deletions include/media/videobuf2-dma-contig.h
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,14 @@
#define _MEDIA_VIDEOBUF2_DMA_COHERENT_H

#include <media/videobuf2-core.h>
#include <linux/dma-mapping.h>

static inline unsigned long vb2_dma_contig_plane_paddr(
struct vb2_buffer *vb, unsigned int plane_no)
static inline dma_addr_t
vb2_dma_contig_plane_paddr(struct vb2_buffer *vb, unsigned int plane_no)
{
return (unsigned long)vb2_plane_cookie(vb, plane_no);
dma_addr_t *paddr = vb2_plane_cookie(vb, plane_no);

return *paddr;
}

void *vb2_dma_contig_init_ctx(struct device *dev);
Expand Down

0 comments on commit 472af2b

Please sign in to comment.