Skip to content

Commit

Permalink
block: move more syncing and invalidation to delete_partition
Browse files Browse the repository at this point in the history
Move the calls to fsync_bdev and __invalidate_device from del_gendisk to
delete_partition.  For the other two callers that check that there are
no openers for the delete partitions(s) the callouts are a no-op as no
file system can be mounted, but this keeps all the cleanup in one
place.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Link: https://lore.kernel.org/r/20210406062303.811835-4-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Christoph Hellwig authored and Jens Axboe committed Apr 8, 2021
1 parent 4561183 commit 473338b
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 7 deletions.
5 changes: 1 addition & 4 deletions block/genhd.c
Original file line number Diff line number Diff line change
Expand Up @@ -686,11 +686,8 @@ void del_gendisk(struct gendisk *disk)

/* invalidate stuff */
disk_part_iter_init(&piter, disk, DISK_PITER_INCL_EMPTY);
while ((part = disk_part_iter_next(&piter))) {
fsync_bdev(part);
__invalidate_device(part, true);
while ((part = disk_part_iter_next(&piter)))
delete_partition(part);
}
disk_part_iter_exit(&piter);

fsync_bdev(disk->part0);
Expand Down
6 changes: 3 additions & 3 deletions block/partitions/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,9 @@ struct device_type part_type = {
*/
void delete_partition(struct block_device *part)
{
fsync_bdev(part);
__invalidate_device(part, true);

xa_erase(&part->bd_disk->part_tbl, part->bd_partno);
kobject_put(part->bd_holder_dir);
device_del(&part->bd_device);
Expand Down Expand Up @@ -468,9 +471,6 @@ int bdev_del_partition(struct block_device *bdev, int partno)
if (part->bd_openers)
goto out_unlock;

sync_blockdev(part);
invalidate_bdev(part);

delete_partition(part);
ret = 0;
out_unlock:
Expand Down

0 comments on commit 473338b

Please sign in to comment.