Skip to content

Commit

Permalink
ARM: dts: BCM5301X: Explicitly disable unused switch CPU ports
Browse files Browse the repository at this point in the history
When redescribing ports I assumed that missing "label" (like "cpu")
means switch port isn't used. That was incorrect and I realized my
change made Linux always use the first (5) CPU port (there are 3 of
them).

While above should technically be possible it often isn't correct:
1. Non-default switch ports are often connected to Ethernet interfaces
   not fully covered by vendor setup (they may miss MACs)
2. On some devices non-default ports require specifying fixed link

This fixes network connectivity for some devices. It was reported &
tested for Netgear R8000. It also affects Linksys EA9200 with its
downstream DTS.

Fixes: ba4aebc ("ARM: dts: BCM5301X: Describe switch ports in the main DTS")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Link: https://lore.kernel.org/r/20231013103314.10306-1-zajec5@gmail.com
Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
  • Loading branch information
Rafał Miłecki authored and Florian Fainelli committed Oct 23, 2023
1 parent b8d4f7c commit 473baea
Show file tree
Hide file tree
Showing 20 changed files with 160 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -181,5 +181,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm4708-luxul-xap-1510.dts
Original file line number Diff line number Diff line change
Expand Up @@ -85,5 +85,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm4708-luxul-xwc-1000.dts
Original file line number Diff line number Diff line change
Expand Up @@ -88,5 +88,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm4708-netgear-r6250.dts
Original file line number Diff line number Diff line change
Expand Up @@ -122,5 +122,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm4708-smartrg-sr400ac.dts
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,14 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};

Expand Down
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm47081-buffalo-wzr-600dhp2.dts
Original file line number Diff line number Diff line change
Expand Up @@ -145,5 +145,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm47081-luxul-xap-1410.dts
Original file line number Diff line number Diff line change
Expand Up @@ -81,5 +81,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm47081-luxul-xwr-1200.dts
Original file line number Diff line number Diff line change
Expand Up @@ -148,5 +148,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm4709-netgear-r8000.dts
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,14 @@
label = "wan";
};

port@5 {
status = "disabled";
};

port@7 {
status = "disabled";
};

port@8 {
label = "cpu";
};
Expand Down
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-885l.dts
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,14 @@
nvmem-cell-names = "mac-address";
};

port@5 {
status = "disabled";
};

port@7 {
status = "disabled";
};

port@8 {
label = "cpu";
};
Expand Down
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm47094-dlink-dir-890l.dts
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,14 @@
label = "wan";
};

port@5 {
status = "disabled";
};

port@7 {
status = "disabled";
};

port@8 {
label = "cpu";
phy-mode = "rgmii";
Expand Down
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm47094-luxul-abr-4500.dts
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm47094-luxul-xap-1610.dts
Original file line number Diff line number Diff line change
Expand Up @@ -120,5 +120,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm47094-luxul-xbr-4500.dts
Original file line number Diff line number Diff line change
Expand Up @@ -107,5 +107,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm47094-luxul-xwc-2000.dts
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm47094-luxul-xwr-3100.dts
Original file line number Diff line number Diff line change
Expand Up @@ -147,5 +147,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm47094-luxul-xwr-3150-v1.dts
Original file line number Diff line number Diff line change
Expand Up @@ -158,5 +158,13 @@
port@5 {
label = "cpu";
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm53015-meraki-mr26.dts
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,14 @@
full-duplex;
};
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};

Expand Down
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm53016-meraki-mr32.dts
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,14 @@
full-duplex;
};
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};

Expand Down
8 changes: 8 additions & 0 deletions arch/arm/boot/dts/broadcom/bcm953012er.dts
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,14 @@
label = "cpu";
ethernet = <&gmac0>;
};

port@7 {
status = "disabled";
};

port@8 {
status = "disabled";
};
};
};

Expand Down

0 comments on commit 473baea

Please sign in to comment.