Skip to content

Commit

Permalink
usb: gadget: lpc32xx_udc: Fix refcount leak in lpc32xx_udc_probe
Browse files Browse the repository at this point in the history
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.
of_node_put() will check NULL pointer.

Fixes: 24a28e4 ("USB: gadget driver for LPC32xx")
Cc: stable <stable@kernel.org>
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Link: https://lore.kernel.org/r/20220603140246.64529-1-linmq006@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Miaoqian Lin authored and Greg Kroah-Hartman committed Jun 10, 2022
1 parent 3755278 commit 4757c9a
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions drivers/usb/gadget/udc/lpc32xx_udc.c
Original file line number Diff line number Diff line change
Expand Up @@ -3016,6 +3016,7 @@ static int lpc32xx_udc_probe(struct platform_device *pdev)
}

udc->isp1301_i2c_client = isp1301_get_client(isp1301_node);
of_node_put(isp1301_node);
if (!udc->isp1301_i2c_client) {
return -EPROBE_DEFER;
}
Expand Down

0 comments on commit 4757c9a

Please sign in to comment.