Skip to content

Commit

Permalink
mtd: atmel_nand: add a definition for the oob reserved bytes
Browse files Browse the repository at this point in the history
It's better to use a macro instead of just a number.

Signed-off-by: Josh Wu <josh.wu@atmel.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
  • Loading branch information
Josh Wu authored and Brian Norris committed Apr 6, 2015
1 parent 3a434f6 commit 477478a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/mtd/nand/atmel_nand.c
Original file line number Diff line number Diff line change
Expand Up @@ -485,7 +485,7 @@ static void pmecc_config_ecc_layout(struct nand_ecclayout *layout,
for (i = 0; i < ecc_len; i++)
layout->eccpos[i] = oobsize - ecc_len + i;

layout->oobfree[0].offset = 2;
layout->oobfree[0].offset = PMECC_OOB_RESERVED_BYTES;
layout->oobfree[0].length =
oobsize - ecc_len - layout->oobfree[0].offset;
}
Expand Down Expand Up @@ -1254,7 +1254,8 @@ static int atmel_pmecc_nand_init_params(struct platform_device *pdev,
nand_chip->ecc.steps = mtd->writesize / sector_size;
nand_chip->ecc.total = nand_chip->ecc.bytes *
nand_chip->ecc.steps;
if (nand_chip->ecc.total > mtd->oobsize - 2) {
if (nand_chip->ecc.total >
mtd->oobsize - PMECC_OOB_RESERVED_BYTES) {
dev_err(host->dev, "No room for ECC bytes\n");
err_no = -EINVAL;
goto err;
Expand Down
3 changes: 3 additions & 0 deletions drivers/mtd/nand/atmel_nand_ecc.h
Original file line number Diff line number Diff line change
Expand Up @@ -152,4 +152,7 @@
/* Time out value for reading PMECC status register */
#define PMECC_MAX_TIMEOUT_MS 100

/* Reserved bytes in oob area */
#define PMECC_OOB_RESERVED_BYTES 2

#endif

0 comments on commit 477478a

Please sign in to comment.