Skip to content

Commit

Permalink
net: phy: marvell: Fix inconsistent indenting in led_blink_set
Browse files Browse the repository at this point in the history
Fix inconsistent indeinting in m88e1318_led_blink_set reported by kernel
test robot, probably done by the presence of an if condition dropped in
later revision of the same code.

Reported-by: kernel test robot <lkp@intel.com>
Link: https://lore.kernel.org/oe-kbuild-all/202304240007.0VEX8QYG-lkp@intel.com/
Fixes: ea9e864 ("net: phy: marvell: Implement led_blink_set()")
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20230423172800.3470-1-ansuelsmth@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Christian Marangi authored and Jakub Kicinski committed Apr 25, 2023
1 parent 700f11e commit 4774ad8
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/net/phy/marvell.c
Original file line number Diff line number Diff line change
Expand Up @@ -2880,10 +2880,10 @@ static int m88e1318_led_blink_set(struct phy_device *phydev, u8 index,
case 1:
case 2:
reg &= ~(0xf << (4 * index));
reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
/* Reset default is 84ms */
*delay_on = 84 / 2;
*delay_off = 84 / 2;
reg |= MII_88E1318S_PHY_LED_FUNC_BLINK << (4 * index);
/* Reset default is 84ms */
*delay_on = 84 / 2;
*delay_off = 84 / 2;
break;
default:
return -EINVAL;
Expand Down

0 comments on commit 4774ad8

Please sign in to comment.