Skip to content

Commit

Permalink
dt-binding: net: ti: am65x-cpts: make reg and compatible required
Browse files Browse the repository at this point in the history
This patch follows K3 CPTS review comments from Rob Herring
<robh@kernel.org>.
 - "reg" and "compatible" properties are required now
 - minor format changes
 - K3 CPTS example added to K3 MCU CPSW bindings

Cc: Rob Herring <robh@kernel.org>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Grygorii Strashko authored and David S. Miller committed May 8, 2020
1 parent a45cfcc commit 4786f4a
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 17 deletions.
15 changes: 14 additions & 1 deletion Documentation/devicetree/bindings/net/ti,k3-am654-cpsw-nuss.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ patternProperties:
description:
CPSW MDIO bus.

"^cpts$":
"^cpts@[0-9a-f]+":
type: object
allOf:
- $ref: "ti,k3-am654-cpts.yaml#"
Expand All @@ -171,6 +171,8 @@ examples:
#include <dt-bindings/pinctrl/k3.h>
#include <dt-bindings/soc/ti,sci_pm_domain.h>
#include <dt-bindings/net/ti-dp83867.h>
#include <dt-bindings/interrupt-controller/irq.h>
#include <dt-bindings/interrupt-controller/arm-gic.h>
mcu_cpsw: ethernet@46000000 {
compatible = "ti,am654-cpsw-nuss";
Expand Down Expand Up @@ -229,4 +231,15 @@ examples:
ti,fifo-depth = <DP83867_PHYCR_FIFO_DEPTH_4_B_NIB>;
};
};
cpts@3d000 {
compatible = "ti,am65-cpts";
reg = <0x0 0x3d000 0x0 0x400>;
clocks = <&k3_clks 18 2>;
clock-names = "cpts";
interrupts-extended = <&gic500 GIC_SPI 858 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "cpts";
ti,cpts-ext-ts-inputs = <4>;
ti,cpts-periodic-outputs = <2>;
};
};
25 changes: 9 additions & 16 deletions Documentation/devicetree/bindings/net/ti,k3-am654-cpts.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ description: |+
properties:
$nodename:
pattern: "^cpts(@.*|-[0-9a-f])*$"
pattern: "^cpts@[0-9a-f]+$"

compatible:
oneOf:
Expand All @@ -52,7 +52,7 @@ properties:
reg:
maxItems: 1
description:
The physical base address and size of CPTS IO range
The physical base address and size of CPTS IO range

reg-names:
items:
Expand All @@ -65,27 +65,27 @@ properties:
items:
- const: cpts

interrupts-extended:
interrupts:
items:
- description: CPTS events interrupt

interrupt-names:
items:
- const: "cpts"
- const: cpts

ti,cpts-ext-ts-inputs:
allOf:
- $ref: /schemas/types.yaml#/definitions/uint32
maximum: 8
description:
Number of hardware timestamp push inputs (HWx_TS_PUSH)
Number of hardware timestamp push inputs (HWx_TS_PUSH)

ti,cpts-periodic-outputs:
allOf:
- $ref: /schemas/types.yaml#/definitions/uint32
maximum: 8
description:
Number of timestamp Generator function outputs (TS_GENFx)
Number of timestamp Generator function outputs (TS_GENFx)

refclk-mux:
type: object
Expand All @@ -107,9 +107,11 @@ properties:
- clocks

required:
- compatible
- reg
- clocks
- clock-names
- interrupts-extended
- interrupts
- interrupt-names

additionalProperties: false
Expand Down Expand Up @@ -140,13 +142,4 @@ examples:
assigned-clock-parents = <&k3_clks 118 11>;
};
};
- |
cpts {
clocks = <&k3_clks 18 2>;
clock-names = "cpts";
interrupts-extended = <&gic500 GIC_SPI 858 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "cpts";
ti,cpts-ext-ts-inputs = <4>;
ti,cpts-periodic-outputs = <2>;
};

0 comments on commit 4786f4a

Please sign in to comment.