Skip to content

Commit

Permalink
lan78xx: Don't reset the interface on open
Browse files Browse the repository at this point in the history
Commit 92571a1 ("lan78xx: Connect phy early") moves the PHY
initialisation into lan78xx_probe, but lan78xx_open subsequently calls
lan78xx_reset. As well as forcing a second round of link negotiation,
this reset frequently prevents the phy interrupt from being generated
(even though the link is up), rendering the interface unusable.

Fix this issue by removing the lan78xx_reset call from lan78xx_open.

Fixes: 92571a1 ("lan78xx: Connect phy early")
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Phil Elwell authored and David S. Miller committed Apr 11, 2018
1 parent 9cf74f5 commit 47b9986
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/net/usb/lan78xx.c
Original file line number Diff line number Diff line change
Expand Up @@ -2515,10 +2515,6 @@ static int lan78xx_open(struct net_device *net)
if (ret < 0)
goto out;

ret = lan78xx_reset(dev);
if (ret < 0)
goto done;

phy_start(net->phydev);

netif_dbg(dev, ifup, dev->net, "phy initialised successfully");
Expand Down

0 comments on commit 47b9986

Please sign in to comment.