Skip to content

Commit

Permalink
lib/stackdepot.c: use flex_array_size() helper in memcpy()
Browse files Browse the repository at this point in the history
Make use of the flex_array_size() helper to calculate the size of a
flexible array member within an enclosing structure.

This helper offers defense-in-depth against potential integer overflows,
while at the same time makes it explicitly clear that we are dealing with
a flexible array member.

Link: https://lkml.kernel.org/r/186e37fe07196ee41a0e562fa8a8cb7a01112ec5.1601565471.git.gustavoars@kernel.org
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Gustavo A. R. Silva authored and Linus Torvalds committed Dec 16, 2020
1 parent 3a2b67e commit 47e684a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/stackdepot.c
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ static struct stack_record *depot_alloc_stack(unsigned long *entries, int size,
stack->handle.slabindex = depot_index;
stack->handle.offset = depot_offset >> STACK_ALLOC_ALIGN;
stack->handle.valid = 1;
memcpy(stack->entries, entries, size * sizeof(unsigned long));
memcpy(stack->entries, entries, flex_array_size(stack, entries, size));
depot_offset += required_size;

return stack;
Expand Down

0 comments on commit 47e684a

Please sign in to comment.