Skip to content

Commit

Permalink
block: fix drain_all condition in blk_drain_queue()
Browse files Browse the repository at this point in the history
When trying to drain all requests, blk_drain_queue() checked only
q->rq.count[]; however, this only tracks REQ_ALLOCED requests.  This
patch updates blk_drain_queue() such that it looks at all the counters
and queues so that request_queue is actually empty on completion.

Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Tejun Heo authored and Jens Axboe committed Dec 13, 2011
1 parent 34f6055 commit 481a7d6
Showing 1 changed file with 18 additions and 6 deletions.
24 changes: 18 additions & 6 deletions block/blk-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,8 @@ EXPORT_SYMBOL(blk_put_queue);
void blk_drain_queue(struct request_queue *q, bool drain_all)
{
while (true) {
int nr_rqs;
bool drain = false;
int i;

spin_lock_irq(q->queue_lock);

Expand All @@ -368,14 +369,25 @@ void blk_drain_queue(struct request_queue *q, bool drain_all)

__blk_run_queue(q);

if (drain_all)
nr_rqs = q->rq.count[0] + q->rq.count[1];
else
nr_rqs = q->rq.elvpriv;
drain |= q->rq.elvpriv;

/*
* Unfortunately, requests are queued at and tracked from
* multiple places and there's no single counter which can
* be drained. Check all the queues and counters.
*/
if (drain_all) {
drain |= !list_empty(&q->queue_head);
for (i = 0; i < 2; i++) {
drain |= q->rq.count[i];
drain |= q->in_flight[i];
drain |= !list_empty(&q->flush_queue[i]);
}
}

spin_unlock_irq(q->queue_lock);

if (!nr_rqs)
if (!drain)
break;
msleep(10);
}
Expand Down

0 comments on commit 481a7d6

Please sign in to comment.