Skip to content

Commit

Permalink
iomap: pass a struct page to iomap_finish_page_writeback
Browse files Browse the repository at this point in the history
No need to pass the full bio_vec.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
  • Loading branch information
Christoph Hellwig authored and Darrick J. Wong committed Oct 21, 2019
1 parent b3d423e commit 48d64cd
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions fs/iomap/buffered-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -1110,21 +1110,21 @@ vm_fault_t iomap_page_mkwrite(struct vm_fault *vmf, const struct iomap_ops *ops)
EXPORT_SYMBOL_GPL(iomap_page_mkwrite);

static void
iomap_finish_page_writeback(struct inode *inode, struct bio_vec *bvec,
iomap_finish_page_writeback(struct inode *inode, struct page *page,
int error)
{
struct iomap_page *iop = to_iomap_page(bvec->bv_page);
struct iomap_page *iop = to_iomap_page(page);

if (error) {
SetPageError(bvec->bv_page);
SetPageError(page);
mapping_set_error(inode->i_mapping, -EIO);
}

WARN_ON_ONCE(i_blocksize(inode) < PAGE_SIZE && !iop);
WARN_ON_ONCE(iop && atomic_read(&iop->write_count) <= 0);

if (!iop || atomic_dec_and_test(&iop->write_count))
end_page_writeback(bvec->bv_page);
end_page_writeback(page);
}

/*
Expand Down Expand Up @@ -1156,7 +1156,7 @@ iomap_finish_ioend(struct iomap_ioend *ioend, int error)

/* walk each page on bio, ending page IO on them */
bio_for_each_segment_all(bv, bio, iter_all)
iomap_finish_page_writeback(inode, bv, error);
iomap_finish_page_writeback(inode, bv->bv_page, error);
bio_put(bio);
}

Expand Down

0 comments on commit 48d64cd

Please sign in to comment.