Skip to content

Commit

Permalink
drm/xe: Move GSC HECI base offsets out of register header
Browse files Browse the repository at this point in the history
These offsets are only used to setup the auxiliary device BAR
information and are never used for driver read/write operations.  Move
them to the GSC HECI file where they're actually used.

Reviewed-by: Lucas De Marchi <lucas.demarchi@intel.com>
Link: https://lore.kernel.org/r/20231214184659.2249559-15-matthew.d.roper@intel.com
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
  • Loading branch information
Matt Roper authored and Rodrigo Vivi committed Dec 21, 2023
1 parent f52e4e9 commit 48e70d2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 0 additions & 4 deletions drivers/gpu/drm/xe/regs/xe_regs.h
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@

#include "regs/xe_reg_defs.h"

#define DG1_GSC_HECI2_BASE 0x00259000
#define PVC_GSC_HECI2_BASE 0x00285000
#define DG2_GSC_HECI2_BASE 0x00374000

#define GT_WAIT_SEMAPHORE_INTERRUPT REG_BIT(11)
#define GT_CONTEXT_SWITCH_INTERRUPT REG_BIT(8)
#define GT_RENDER_PIPECTL_NOTIFY_INTERRUPT REG_BIT(4)
Expand Down
4 changes: 4 additions & 0 deletions drivers/gpu/drm/xe/xe_heci_gsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@

#define GSC_BAR_LENGTH 0x00000FFC

#define DG1_GSC_HECI2_BASE 0x259000
#define PVC_GSC_HECI2_BASE 0x285000
#define DG2_GSC_HECI2_BASE 0x374000

static void heci_gsc_irq_mask(struct irq_data *d)
{
/* generic irq handling */
Expand Down

0 comments on commit 48e70d2

Please sign in to comment.