Skip to content

Commit

Permalink
ALSA: hda - Reduce verbs by node power-saves
Browse files Browse the repository at this point in the history
The widget (node) power-saves restore the widget states at each
transition from D3 to D0 on each node.  This was added in the commit
[d545a57:ALSA: hda - Sync node attributes at resume from widget
power saving].  However, the test was rater false-positive; this
wasn't needed for any codecs.

Since the resync may take significant number of additional verbs to be
executed, it's better to reduce it.  Let's disable it for now again.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Iwai committed May 20, 2015
1 parent 976fa9a commit 48f4b3a
Showing 1 changed file with 8 additions and 0 deletions.
8 changes: 8 additions & 0 deletions sound/pci/hda/hda_generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -844,8 +844,16 @@ static hda_nid_t path_power_update(struct hda_codec *codec,
snd_hda_codec_write(codec, nid, 0,
AC_VERB_SET_POWER_STATE, state);
changed = nid;
/* all known codecs seem to be capable to handl
* widgets state even in D3, so far.
* if any new codecs need to restore the widget
* states after D0 transition, call the function
* below.
*/
#if 0 /* disabled */
if (state == AC_PWRST_D0)
snd_hdac_regmap_sync_node(&codec->core, nid);
#endif
}
}
return changed;
Expand Down

0 comments on commit 48f4b3a

Please sign in to comment.