Skip to content

Commit

Permalink
mmc: sdhci-of-dwcmshc: Add runtime PM operations
Browse files Browse the repository at this point in the history
This commit implements the runtime PM operations to disable eMMC card clock
when idle.

Reviewed-by: David Thompson <davthompson@nvidia.com>
Signed-off-by: Liming Sun <limings@nvidia.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
Link: https://lore.kernel.org/r/20230822195929.168552-2-limings@nvidia.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
  • Loading branch information
Liming Sun authored and Ulf Hansson committed Aug 24, 2023
1 parent a11937b commit 48fe8fa
Showing 1 changed file with 62 additions and 2 deletions.
64 changes: 62 additions & 2 deletions drivers/mmc/host/sdhci-of-dwcmshc.c
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include <linux/module.h>
#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/pm_runtime.h>
#include <linux/reset.h>
#include <linux/sizes.h>

Expand Down Expand Up @@ -548,9 +549,13 @@ static int dwcmshc_probe(struct platform_device *pdev)

host->mmc->caps |= MMC_CAP_WAIT_WHILE_BUSY;

pm_runtime_get_noresume(dev);
pm_runtime_set_active(dev);
pm_runtime_enable(dev);

err = sdhci_setup_host(host);
if (err)
goto err_clk;
goto err_rpm;

if (rk_priv)
dwcmshc_rk35xx_postinit(host, priv);
Expand All @@ -559,10 +564,15 @@ static int dwcmshc_probe(struct platform_device *pdev)
if (err)
goto err_setup_host;

pm_runtime_put(dev);

return 0;

err_setup_host:
sdhci_cleanup_host(host);
err_rpm:
pm_runtime_disable(dev);
pm_runtime_put_noidle(dev);
err_clk:
clk_disable_unprepare(pltfm_host->clk);
clk_disable_unprepare(priv->bus_clk);
Expand Down Expand Up @@ -600,6 +610,8 @@ static int dwcmshc_suspend(struct device *dev)
struct rk35xx_priv *rk_priv = priv->priv;
int ret;

pm_runtime_resume(dev);

ret = sdhci_suspend_host(host);
if (ret)
return ret;
Expand Down Expand Up @@ -659,7 +671,55 @@ static int dwcmshc_resume(struct device *dev)
}
#endif

static SIMPLE_DEV_PM_OPS(dwcmshc_pmops, dwcmshc_suspend, dwcmshc_resume);
#ifdef CONFIG_PM

static void dwcmshc_enable_card_clk(struct sdhci_host *host)
{
u16 ctrl;

ctrl = sdhci_readw(host, SDHCI_CLOCK_CONTROL);
if ((ctrl & SDHCI_CLOCK_INT_EN) && !(ctrl & SDHCI_CLOCK_CARD_EN)) {
ctrl |= SDHCI_CLOCK_CARD_EN;
sdhci_writew(host, ctrl, SDHCI_CLOCK_CONTROL);
}
}

static void dwcmshc_disable_card_clk(struct sdhci_host *host)
{
u16 ctrl;

ctrl = sdhci_readw(host, SDHCI_CLOCK_CONTROL);
if (ctrl & SDHCI_CLOCK_CARD_EN) {
ctrl &= ~SDHCI_CLOCK_CARD_EN;
sdhci_writew(host, ctrl, SDHCI_CLOCK_CONTROL);
}
}

static int dwcmshc_runtime_suspend(struct device *dev)
{
struct sdhci_host *host = dev_get_drvdata(dev);

dwcmshc_disable_card_clk(host);

return 0;
}

static int dwcmshc_runtime_resume(struct device *dev)
{
struct sdhci_host *host = dev_get_drvdata(dev);

dwcmshc_enable_card_clk(host);

return 0;
}

#endif

static const struct dev_pm_ops dwcmshc_pmops = {
SET_SYSTEM_SLEEP_PM_OPS(dwcmshc_suspend, dwcmshc_resume)
SET_RUNTIME_PM_OPS(dwcmshc_runtime_suspend,
dwcmshc_runtime_resume, NULL)
};

static struct platform_driver sdhci_dwcmshc_driver = {
.driver = {
Expand Down

0 comments on commit 48fe8fa

Please sign in to comment.