Skip to content

Commit

Permalink
Merge branch 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/…
Browse files Browse the repository at this point in the history
…linux/kernel/git/tip/tip

Pull objtool relocation fixes from Ingo Molnar:
 "Two fixes related to the module loading regression introduced by the
  recent objtool changes"

* 'core-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip:
  objtool, modules: Discard objtool annotation sections for modules
  objtool, compiler.h: Fix __unreachable section relocation size
  • Loading branch information
Linus Torvalds committed Mar 2, 2017
2 parents 8f03cf5 + e390f9a commit 4977ab6
Show file tree
Hide file tree
Showing 6 changed files with 11 additions and 9 deletions.
2 changes: 0 additions & 2 deletions arch/x86/kernel/vmlinux.lds.S
Original file line number Diff line number Diff line change
Expand Up @@ -345,8 +345,6 @@ SECTIONS
DISCARDS
/DISCARD/ : {
*(.eh_frame)
*(__func_stack_frame_non_standard)
*(__unreachable)
}
}

Expand Down
4 changes: 2 additions & 2 deletions include/linux/compiler-gcc.h
Original file line number Diff line number Diff line change
Expand Up @@ -200,8 +200,8 @@
#ifdef CONFIG_STACK_VALIDATION
#define annotate_unreachable() ({ \
asm("%c0:\t\n" \
".pushsection __unreachable, \"a\"\t\n" \
".long %c0b\t\n" \
".pushsection .discard.unreachable\t\n" \
".long %c0b - .\t\n" \
".popsection\t\n" : : "i" (__LINE__)); \
})
#else
Expand Down
2 changes: 1 addition & 1 deletion include/linux/frame.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
* For more information, see tools/objtool/Documentation/stack-validation.txt.
*/
#define STACK_FRAME_NON_STANDARD(func) \
static void __used __section(__func_stack_frame_non_standard) \
static void __used __section(.discard.func_stack_frame_non_standard) \
*__func_stack_frame_non_standard_##func = func

#else /* !CONFIG_STACK_VALIDATION */
Expand Down
1 change: 1 addition & 0 deletions scripts/mod/modpost.c
Original file line number Diff line number Diff line change
Expand Up @@ -854,6 +854,7 @@ static const char *const section_white_list[] =
".cmem*", /* EZchip */
".fmt_slot*", /* EZchip */
".gnu.lto*",
".discard.*",
NULL
};

Expand Down
5 changes: 4 additions & 1 deletion scripts/module-common.lds
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,10 @@
* combine them automatically.
*/
SECTIONS {
/DISCARD/ : { *(.discard) }
/DISCARD/ : {
*(.discard)
*(.discard.*)
}

__ksymtab 0 : { *(SORT(___ksymtab+*)) }
__ksymtab_gpl 0 : { *(SORT(___ksymtab_gpl+*)) }
Expand Down
6 changes: 3 additions & 3 deletions tools/objtool/builtin-check.c
Original file line number Diff line number Diff line change
Expand Up @@ -339,13 +339,13 @@ static int add_dead_ends(struct objtool_file *file)
struct instruction *insn;
bool found;

sec = find_section_by_name(file->elf, ".rela__unreachable");
sec = find_section_by_name(file->elf, ".rela.discard.unreachable");
if (!sec)
return 0;

list_for_each_entry(rela, &sec->rela_list, list) {
if (rela->sym->type != STT_SECTION) {
WARN("unexpected relocation symbol type in .rela__unreachable");
WARN("unexpected relocation symbol type in %s", sec->name);
return -1;
}
insn = find_insn(file, rela->sym->sec, rela->addend);
Expand Down Expand Up @@ -1272,7 +1272,7 @@ int cmd_check(int argc, const char **argv)

INIT_LIST_HEAD(&file.insn_list);
hash_init(file.insn_hash);
file.whitelist = find_section_by_name(file.elf, "__func_stack_frame_non_standard");
file.whitelist = find_section_by_name(file.elf, ".discard.func_stack_frame_non_standard");
file.rodata = find_section_by_name(file.elf, ".rodata");
file.ignore_unreachables = false;
file.c_file = find_section_by_name(file.elf, ".comment");
Expand Down

0 comments on commit 4977ab6

Please sign in to comment.