Skip to content

Commit

Permalink
ALSA: oxfw: fix memory leak of private data
Browse files Browse the repository at this point in the history
Although private data of sound card instance is usually allocated in the
tail of the instance, drivers in ALSA firewire stack allocate the private
data before allocating the instance. In this case, the private data
should be released explicitly at .private_free callback of the instance.

This commit fixes memory leak following to the above design.

Fixes: 6c29230 ('ALSA: oxfw: delayed registration of sound card')
Cc: <stable@vger.kernel.org> # v4.7+
Signed-off-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
  • Loading branch information
Takashi Sakamoto authored and Takashi Iwai committed Sep 13, 2018
1 parent 8d28277 commit 498fe23
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions sound/firewire/oxfw/oxfw.c
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@ static void oxfw_free(struct snd_oxfw *oxfw)

kfree(oxfw->spec);
mutex_destroy(&oxfw->mutex);
kfree(oxfw);
}

/*
Expand Down

0 comments on commit 498fe23

Please sign in to comment.