Skip to content

Commit

Permalink
nfc: refined function nci_hci_resp_received
Browse files Browse the repository at this point in the history
We don't use the parameter result actually, so better to remove it and
skip a gcc warning for unused variable.

Signed-off-by: Alex Shi <alex.shi@linux.alibaba.com>
Link: https://lore.kernel.org/r/1605239517-49707-1-git-send-email-alex.shi@linux.alibaba.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Alex Shi authored and Jakub Kicinski committed Nov 15, 2020
1 parent 508c4fc commit 49b1cab
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions net/nfc/nci/hci.c
Original file line number Diff line number Diff line change
Expand Up @@ -363,16 +363,13 @@ static void nci_hci_cmd_received(struct nci_dev *ndev, u8 pipe,
}

static void nci_hci_resp_received(struct nci_dev *ndev, u8 pipe,
u8 result, struct sk_buff *skb)
struct sk_buff *skb)
{
struct nci_conn_info *conn_info;
u8 status = result;

conn_info = ndev->hci_dev->conn_info;
if (!conn_info) {
status = NCI_STATUS_REJECTED;
if (!conn_info)
goto exit;
}

conn_info->rx_skb = skb;

Expand All @@ -388,7 +385,7 @@ static void nci_hci_hcp_message_rx(struct nci_dev *ndev, u8 pipe,
{
switch (type) {
case NCI_HCI_HCP_RESPONSE:
nci_hci_resp_received(ndev, pipe, instruction, skb);
nci_hci_resp_received(ndev, pipe, skb);
break;
case NCI_HCI_HCP_COMMAND:
nci_hci_cmd_received(ndev, pipe, instruction, skb);
Expand Down

0 comments on commit 49b1cab

Please sign in to comment.