Skip to content

Commit

Permalink
perf beauty sockaddr: Fix augmented syscall format warning
Browse files Browse the repository at this point in the history
The sockaddr related examples given in
`tools/perf/examples/bpf/augmented_syscalls.c` almost always use `long`s
to represent most of their fields.

However, `size_t syscall_arg__scnprintf_sockaddr(..)` has a `scnprintf`
call that uses `"%#x"` as format string.

This throws a warning (whenever the syscall argument is `unsigned
long`).

Added `l` identifier to indicate that the `arg->value` is an unsigned
long.

Not sure about the complications of this with x86 though.

Signed-off-by: Cengiz Can <cengiz@kernel.wtf>
Cc: Peter Zijlstra <peterz@infradead.org>
Link: http://lore.kernel.org/lkml/20200113174438.102975-1-cengiz@kernel.wtf
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
  • Loading branch information
Cengiz Can authored and Arnaldo Carvalho de Melo committed Jan 14, 2020
1 parent 93e843f commit 49e0b6f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tools/perf/trace/beauty/sockaddr.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,5 @@ size_t syscall_arg__scnprintf_sockaddr(char *bf, size_t size, struct syscall_arg
if (arg->augmented.args)
return syscall_arg__scnprintf_augmented_sockaddr(arg, bf, size);

return scnprintf(bf, size, "%#x", arg->val);
return scnprintf(bf, size, "%#lx", arg->val);
}

0 comments on commit 49e0b6f

Please sign in to comment.