Skip to content

Commit

Permalink
block: misplaced rq_complete tracepoint
Browse files Browse the repository at this point in the history
The rq_complete tracepoint was never issued for empty requests,
causing the resulting blktrace information to never show any
completion for those request.

Signed-off-by: Hannes Reinecke <hare@suse.de>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <axboe@fb.com>
  • Loading branch information
Hannes Reinecke authored and Jens Axboe committed Oct 1, 2014
1 parent c611529 commit 4a0efdc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions block/blk-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -2400,11 +2400,11 @@ bool blk_update_request(struct request *req, int error, unsigned int nr_bytes)
{
int total_bytes;

trace_block_rq_complete(req->q, req, nr_bytes);

if (!req->bio)
return false;

trace_block_rq_complete(req->q, req, nr_bytes);

/*
* For fs requests, rq is just carrier of independent bio's
* and each partial completion should be handled separately.
Expand Down

0 comments on commit 4a0efdc

Please sign in to comment.