Skip to content

Commit

Permalink
drivers/mailbox/omap: make mbox->irq signed for error handling
Browse files Browse the repository at this point in the history
There is a bug in omap2_mbox_probe() where we try do:

		mbox->irq = platform_get_irq(pdev, info->irq_id);
		if (mbox->irq < 0) {

The problem is that mbox->irq is unsigned so the error handling doesn't
work.  I've changed it to a signed integer.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Suman Anna <s-anna@ti.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Omar Ramirez Luna <omar.ramirez@copitl.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
Dan Carpenter authored and Linus Torvalds committed Jan 24, 2014
1 parent 0c79a8e commit 4a102b4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/mailbox/omap-mbox.h
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ struct omap_mbox_queue {

struct omap_mbox {
const char *name;
unsigned int irq;
int irq;
struct omap_mbox_queue *txq, *rxq;
struct omap_mbox_ops *ops;
struct device *dev;
Expand Down

0 comments on commit 4a102b4

Please sign in to comment.