Skip to content

Commit

Permalink
mm/damon/dbgfs: use operations id for knowing if the target has pid
Browse files Browse the repository at this point in the history
DAMON debugfs interface depends on monitoring operations for virtual
address spaces because it knows if the target has pid or not by seeing if
the context is configured to use one of the virtual address space
monitoring operation functions.  We can replace that check with 'enum
damon_ops_id' now, to make it independent.  This commit makes the change.

Link: https://lkml.kernel.org/r/20220215184603.1479-7-sj@kernel.org
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: David Rientjes <rientjes@google.com>
Cc: Xin Hao <xhao@linux.alibaba.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
  • Loading branch information
SeongJae Park authored and Linus Torvalds committed Mar 22, 2022
1 parent da7aaca commit 4a20865
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions mm/damon/dbgfs.c
Original file line number Diff line number Diff line change
@@ -277,7 +277,7 @@ static ssize_t dbgfs_schemes_write(struct file *file, const char __user *buf,

static inline bool target_has_pid(const struct damon_ctx *ctx)
{
return ctx->ops.target_valid == damon_va_target_valid;
return ctx->ops.id == DAMON_OPS_VADDR;
}

static ssize_t sprint_target_ids(struct damon_ctx *ctx, char *buf, ssize_t len)
@@ -741,8 +741,8 @@ static struct damon_ctx *dbgfs_new_ctx(void)
if (!ctx)
return NULL;

if (damon_select_ops(ctx, DAMON_OPS_VADDR) && damon_select_ops(ctx,
DAMON_OPS_PADDR)) {
if (damon_select_ops(ctx, DAMON_OPS_VADDR) &&
damon_select_ops(ctx, DAMON_OPS_PADDR)) {
damon_destroy_ctx(ctx);
return NULL;
}

0 comments on commit 4a20865

Please sign in to comment.