Skip to content

Commit

Permalink
of/irq: Pass trigger type in IRQ resource flags
Browse files Browse the repository at this point in the history
Some drivers might rely on availability of trigger flags in IRQ
resource, for example to configure the hardware for particular interrupt
type. However current code creating IRQ resources from data in device
tree does not configure trigger flags in resulting resources.

This patch tries to solve the problem, based on the fact that
irq_of_parse_and_map() configures the trigger based on DT interrupt
specifier and IRQD_TRIGGER_* flags are consistent with IORESOURCE_IRQ_*,
and we can get correct trigger flags by calling irqd_get_trigger_type()
after mapping the interrupt.

Signed-off-by: Tomasz Figa <tomasz.figa@gmail.com>
[grant.likely: Merged the two assignments to r->flags]
Signed-off-by: Grant Likely <grant.likely@linaro.org>
  • Loading branch information
Tomasz Figa authored and Grant Likely committed Oct 15, 2013
1 parent 8804827 commit 4a43d68
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/of/irq.c
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@ int of_irq_to_resource(struct device_node *dev, int index, struct resource *r)
&name);

r->start = r->end = irq;
r->flags = IORESOURCE_IRQ;
r->flags = IORESOURCE_IRQ | irqd_get_trigger_type(irq_get_irq_data(irq));
r->name = name ? name : of_node_full_name(dev);
}

Expand Down

0 comments on commit 4a43d68

Please sign in to comment.