Skip to content

Commit

Permalink
block: remove the initialize_rq_fn blk_mq_ops method
Browse files Browse the repository at this point in the history
Entirely unused now.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Link: https://lore.kernel.org/r/20211021060607.264371-7-hch@lst.de
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Christoph Hellwig authored and Jens Axboe committed Oct 22, 2021
1 parent 68ec3b8 commit 4abafdc
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 13 deletions.
9 changes: 1 addition & 8 deletions block/blk-core.c
Original file line number Diff line number Diff line change
Expand Up @@ -606,16 +606,9 @@ EXPORT_SYMBOL(blk_get_queue);
struct request *blk_get_request(struct request_queue *q, unsigned int op,
blk_mq_req_flags_t flags)
{
struct request *req;

WARN_ON_ONCE(op & REQ_NOWAIT);
WARN_ON_ONCE(flags & ~(BLK_MQ_REQ_NOWAIT | BLK_MQ_REQ_PM));

req = blk_mq_alloc_request(q, op, flags);
if (!IS_ERR(req) && q->mq_ops->initialize_rq_fn)
q->mq_ops->initialize_rq_fn(req);

return req;
return blk_mq_alloc_request(q, op, flags);
}
EXPORT_SYMBOL(blk_get_request);

Expand Down
5 changes: 0 additions & 5 deletions include/linux/blk-mq.h
Original file line number Diff line number Diff line change
Expand Up @@ -566,11 +566,6 @@ struct blk_mq_ops {
void (*exit_request)(struct blk_mq_tag_set *set, struct request *,
unsigned int);

/**
* @initialize_rq_fn: Called from inside blk_get_request().
*/
void (*initialize_rq_fn)(struct request *rq);

/**
* @cleanup_rq: Called before freeing one request which isn't completed
* yet, and usually for freeing the driver private data.
Expand Down

0 comments on commit 4abafdc

Please sign in to comment.